Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the order of datasets and grid registrations #2276

Merged
merged 3 commits into from
Dec 26, 2022

Conversation

seisman
Copy link
Member

@seisman seisman commented Dec 26, 2022

Description of proposed changes

  • Update the order of grid registrations from ["pixel", "gridline"] to ["gridline", "pixel"]
  • Sort datasets alphabetically based on dict keys

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Dec 26, 2022
@seisman seisman added this to the 0.8.0 milestone Dec 26, 2022
@yvonnefroehlich yvonnefroehlich mentioned this pull request Dec 26, 2022
65 tasks
@michaelgrund michaelgrund added the final review call This PR requires final review and approval from a second reviewer label Dec 26, 2022
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Dec 26, 2022
@seisman seisman merged commit 7c67cf0 into main Dec 26, 2022
@seisman seisman deleted the remote-dataset-registrations branch December 26, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants