Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Fix the comment format of the dvc-diff workflow #2359

Merged
merged 1 commit into from
Feb 12, 2023
Merged

Conversation

seisman
Copy link
Member

@seisman seisman commented Feb 12, 2023

Description of proposed changes

First found in #2208 (comment) and reported in #2340.

The comment posted by the dvc-diff workflow is badly formatted, likely due to unknown github changes:
image

This PR fixes the issue by saving the report content into the report output parameter using the multiline string syntax.

References:

  1. Clarify how multiline output values can be set via GITHUB_OUTPUT github/docs#21529
  2. https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#example-of-a-multiline-string

Changes in this PR were tested in PR #2340. Please see the revision history of the comment #2208 (comment).

@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Feb 12, 2023
@seisman seisman added this to the 0.9.0 milestone Feb 12, 2023
@seisman seisman requested a review from weiji14 February 12, 2023 07:03
@seisman seisman added the needs review This PR has higher priority and needs review. label Feb 12, 2023
@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Feb 12, 2023
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Feb 12, 2023
@seisman seisman merged commit 2482761 into main Feb 12, 2023
@seisman seisman deleted the fix-dvc-comment branch February 12, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants