Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention GMT docs regarding more complicated legends in gallery example "Legends" #2606

Merged
merged 4 commits into from
Jul 19, 2023

Conversation

yvonnefroehlich
Copy link
Member

@yvonnefroehlich yvonnefroehlich commented Jul 16, 2023

Description of proposed changes

This PR aims to mention the upstream GMT documentation regarding more complicated legends in the gallery example Legends.

Related to issue #2603.

Preview: https://pygmt-dev--2606.org.readthedocs.build/en/2606/gallery/embellishments/legend.html

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@yvonnefroehlich yvonnefroehlich added documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog labels Jul 16, 2023
@yvonnefroehlich yvonnefroehlich added this to the 0.10.0 milestone Jul 16, 2023
examples/gallery/embellishments/legend.py Outdated Show resolved Hide resolved
@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Jul 18, 2023
@seisman seisman merged commit 953b0e9 into main Jul 19, 2023
7 checks passed
@seisman seisman deleted the mention-legend-file branch July 19, 2023 12:16
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants