Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable pylint's line-length checking #2735

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Conversation

seisman
Copy link
Member

@seisman seisman commented Oct 10, 2023

Description of proposed changes

flakeheaven/pycodestyle already set the line-length limit to 79, so it makes no sense to check line-length again by pylint.

This PR disables pylint's line-length checking.

Address #2728 (comment).

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added the maintenance Boring but important stuff for the core devs label Oct 10, 2023
@seisman seisman added this to the 0.11.0 milestone Oct 10, 2023
@seisman seisman added the needs review This PR has higher priority and needs review. label Oct 10, 2023
@weiji14 weiji14 added skip-changelog Skip adding Pull Request to changelog and removed needs review This PR has higher priority and needs review. labels Oct 10, 2023
@weiji14 weiji14 merged commit ae474c6 into main Oct 10, 2023
16 checks passed
@weiji14 weiji14 deleted the pylint/disable-line-length-check branch October 10, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants