Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote datasets: Update filenames of remote dataset images #2745

Merged
merged 1 commit into from
Oct 14, 2023

Conversation

yvonnefroehlich
Copy link
Member

@yvonnefroehlich yvonnefroehlich commented Oct 14, 2023

Description of proposed changes

This PR aims to update the filenames of the remote dataset images.
Some of the images are in png and some are in jpg format.

Related to GMT PR GenericMappingTools/remote-datasets#89
Related to PyGMT PR #2728

Preview: https://pygmt-dev--2745.org.readthedocs.build/en/2745/api/index.html#datasets

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@yvonnefroehlich yvonnefroehlich added documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog labels Oct 14, 2023
@yvonnefroehlich yvonnefroehlich added this to the 0.11.0 milestone Oct 14, 2023
@yvonnefroehlich yvonnefroehlich self-assigned this Oct 14, 2023
@seisman seisman merged commit c9d6147 into main Oct 14, 2023
16 checks passed
@seisman seisman deleted the update-names-datasets branch October 14, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants