Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Pin ghostscript to 9.54.0 in Tests and Dev Tests workflows #2754

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

seisman
Copy link
Member

@seisman seisman commented Oct 18, 2023

Description of proposed changes

The latest gs version is 10.02.0 but our baseline images were generated with gs 9.54.0, thus we will have lots of failures if we use gs 10.02.0 (see PR #2694).

We should update our gs to 10.02.0 and update all baseline images, but we decided to wait for GMT 6.5 first (#2694 (comment)) so that we don't have to update baseline images twice in a short period.

In this PR, Ghostscript is pinned to 9.54.0 for the Tests and Dev Tests workflow, so that we don't have failures due to gs 10.02.0. Other workflows are not changed because they don't care about the gs version.

We will pin Ghostscript to 10.02.0 in PR #2694.

@seisman seisman changed the title CI: Pin ghostscript to 9.54.0 CI: Pin ghostscript to 9.54.0 in Tests and Dev Tests workflows Oct 18, 2023
@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Oct 18, 2023
@seisman seisman added this to the 0.11.0 milestone Oct 18, 2023
@seisman seisman added the needs review This PR has higher priority and needs review. label Oct 18, 2023
@seisman seisman requested a review from a team October 18, 2023 09:03
Copy link
Member

@yvonnefroehlich yvonnefroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One issue with gs version 10.02.0 is that the (semi-)transparency is (again) broken.

@seisman
Copy link
Member Author

seisman commented Oct 18, 2023

One issue with gs version 10.02.0 is that the (semi-)transparency is (again) broken.

yes, gs 10.02.0 works well with GMT 6.5.0

@seisman seisman removed the needs review This PR has higher priority and needs review. label Oct 18, 2023
@seisman seisman merged commit ed47ce5 into main Oct 18, 2023
16 checks passed
@seisman seisman deleted the pin-gs-954 branch October 18, 2023 10:08
@weiji14 weiji14 mentioned this pull request Oct 24, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants