-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figure.savefig: Add the 'worldfile' parameter to write a companion world file for raster images #2766
Merged
Merged
Figure.savefig: Add the 'worldfile' parameter to write a companion world file for raster images #2766
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
797e5c6
Figure.savefig: Add the 'worldfile' parameter to write a companion wo…
seisman a36cef7
Fix pylint issue
seisman 0c4c9d3
Merge branch 'main' into savefig/worldfile
seisman 184d5b1
Apply suggestions from code review
seisman 3139130
Apply suggestions from code review
seisman 20e79db
Test bmp
seisman 6062666
Fix formatting styles
seisman 57c020f
Fix bmp to .bmp
seisman e50ab6d
Merge branch 'main' into savefig/worldfile
seisman da5c6d2
PDF and EPS is not supportd
seisman a863132
Combine two tests into a single one
seisman 316e5df
Fix the docstrings
seisman 2c149bb
Merge branch 'main' into savefig/worldfile
seisman 1784a2f
Update pygmt/tests/test_figure.py
seisman 9dc40fc
Update pygmt/figure.py
seisman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was there a reason to switch from the parametrized tests to a single test in a863132? It'll be harder to see which formats/extensions fail, if e.g. the first one in a list like ['.bmp', '.jpg', ...] raises an AssertionError, because the others in the list won't be tested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main idea is to reducing the number of tests and also testing times. Comparing https://github.com/GenericMappingTools/pygmt/actions/runs/6677102075/job/18146781350?pr=2766 and https://github.com/GenericMappingTools/pygmt/actions/runs/6648648090/job/18065964154?pr=2766, the old way (using
parametrize
) has 7 tests for worldfile, and the testing time is 0.5 * 5 + 0.25 * 2 = 3 seconds, while the new way (a single test) costs 1.5 s only.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ok, I see that we avoid having to call
fig.basemap
multiple times, so it will be faster. All good then.