Release Drafter: Automatically replace GitHub handles with names and links #2777
Conversation
.github/release-drafter.yml
Outdated
| @@ -27,6 +27,19 @@ exclude-contributors: | |||
| category-template: '### $TITLE' | |||
| change-template: '* $TITLE ([#$NUMBER]($URL))' | |||
| sort-by: 'title' | |||
| replacers: | |||
| - search: '/@(\w+)(,\s| and )?/g' | |||
| replace: '- [@$1](https://github.com/$1)\\n' | |||
There was a problem hiding this comment.
This is probably more for my understanding: Why are there now two backslashes (\\) before the n? In comment #2775 (comment) it was only one backslash (\).
There was a problem hiding this comment.
I first tried \n, then found it didn't work, then tried \\n, still no luck.
The above regex produces the following output:
It's likely because Markdown doesn't support In commit 4f8236a, I've changed the regex to The new regex produces: It looks good to me. When making a new release, we just need to convert it to a bulleted list and sort the names based on number of commits. |
michaelgrund
added
final review call
Co-authored-by: Yvonne Fröhlich <[email protected]>
Co-authored-by: Yvonne Fröhlich <[email protected]>
| - search: '@maxrjones' | ||
| replace: 'Max Jones' | ||
| - search: '@michaelgrund' | ||
| replace: 'Michael Grund' | ||
| - search: '@seisman' | ||
| replace: 'Dongdong Tian' |
There was a problem hiding this comment.
They're already sorted alphabetically by GitHub handles, no?
There was a problem hiding this comment.
Oh right, was looking at full names, nvm.
seisman
removed
the
final review call
Description of proposed changes
Closes #2775.
The
replacersalmost works, but it has some trouble with newlines\n.In my own fork, the draft release (https://github.com/seisman/pygmt/releases, but it's likely you can't see a draft release) looks like this:
