Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Mypy for static type checking #2808
Add Mypy for static type checking #2808
Changes from 13 commits
c1bd0be
594e07e
16da12b
fec7e8b
ebe7d50
85e7128
2310e7e
9dc8c98
dda26d4
97d3dbc
8b2a5b9
aed77ad
9fd5a04
fa44524
e62dcb6
ec25885
73c9863
4d31ce3
a7545ad
49e67d5
253a491
567bfb8
5e401c2
cd9d3ed
9bfe49a
f230b0d
0e657bd
30b45c1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't used this before, but could we use
mypy --install-types ...
following https://github.com/pydata/xarray/blob/f7edd1e8c2d6d1a8668cc8baba9e1c66d87b8bb4/.github/workflows/ci-additional.yaml#L124C14-L124C14 instead of listing all these dependencies?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't work. The doc says:
So it only works for pandas which maintains a separate stub package
pandas-stubs
and can't install packages like numpy.I tried to create a fresh environment and run
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe move this under the
# Dev dependencies (style checks)
section?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to keep them in a separate section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the following error:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To suppress the following error:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some packages like geopandas don't provide type hints and mypy reports following errors:
Ignore these errors following https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports.