Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TYP: Add type hints for 'data_source' in load_earth_relief and load_earth_magnetic_anomaly functions #2849

Merged
merged 4 commits into from
Dec 8, 2023

Conversation

seisman
Copy link
Member

@seisman seisman commented Dec 5, 2023

Description of proposed changes

Address #2812.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added maintenance Boring but important stuff for the core devs typing Type hints and static type checking labels Dec 5, 2023
@seisman seisman added this to the 0.11.0 milestone Dec 5, 2023
@seisman seisman added the needs review This PR has higher priority and needs review. label Dec 5, 2023
@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Dec 5, 2023
pygmt/datasets/earth_magnetic_anomaly.py Outdated Show resolved Hide resolved
pygmt/datasets/earth_relief.py Outdated Show resolved Hide resolved
@seisman
Copy link
Member Author

seisman commented Dec 6, 2023

Need to wait for #2855 and #2813.

@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Dec 8, 2023
@seisman seisman merged commit 3812c99 into main Dec 8, 2023
16 of 17 checks passed
@seisman seisman deleted the typing/data-source branch December 8, 2023 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs typing Type hints and static type checking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants