-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update min/max value of remote datasets for recent upstream changes #2978
Conversation
Ok with removing the min/max value checks, but we should still have some check to ensure that the pixel values returned are valid. Maybe something like a |
It means we still need to update these statistical values when the datasets change. |
I've added the checks of min/max values back to the tests. It means more maintenance burden but at least the values can make sure that the loaded data have reasonable values. |
Description of proposed changes
See #2961 (comment) for context.
The min/max values of remote datasets are out of our control so it makes little sense to check them in PyGMT tests. This PR remove all checks about min/max values of remote datasets, with one exception
earth_mask
, since we know that the earth_mask dataset has discrete values from 0 to 4.