Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update min/max value of remote datasets for recent upstream changes #2978

Merged
merged 7 commits into from
Jan 14, 2024

Conversation

seisman
Copy link
Member

@seisman seisman commented Jan 9, 2024

Description of proposed changes

See #2961 (comment) for context.

The min/max values of remote datasets are out of our control so it makes little sense to check them in PyGMT tests. This PR remove all checks about min/max values of remote datasets, with one exception earth_mask, since we know that the earth_mask dataset has discrete values from 0 to 4.

@seisman seisman mentioned this pull request Jan 9, 2024
14 tasks
@seisman seisman changed the title Fix failures about remote datasets Fix remote dataset failures by removing the checks of min/max values Jan 10, 2024
@seisman seisman marked this pull request as ready for review January 10, 2024 05:31
@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Jan 10, 2024
@seisman seisman added this to the 0.11.0 milestone Jan 10, 2024
@michaelgrund michaelgrund added the final review call This PR requires final review and approval from a second reviewer label Jan 10, 2024
@weiji14
Copy link
Member

weiji14 commented Jan 11, 2024

Ok with removing the min/max value checks, but we should still have some check to ensure that the pixel values returned are valid. Maybe something like a notnull() check, or some other statistical measure?

@seisman
Copy link
Member Author

seisman commented Jan 11, 2024

Maybe something like a notnull() check,

notnull() checks make no sense to some datasets (e.g., earth_age), which contains NaN values.

or some other statistical measure?

It means we still need to update these statistical values when the datasets change.

@seisman seisman changed the title Fix remote dataset failures by removing the checks of min/max values Update min/max value of remote datasets for recent upstream changes Jan 12, 2024
@seisman
Copy link
Member Author

seisman commented Jan 12, 2024

I've added the checks of min/max values back to the tests. It means more maintenance burden but at least the values can make sure that the loaded data have reasonable values.

@seisman seisman merged commit 89a51c0 into main Jan 14, 2024
8 of 14 checks passed
@seisman seisman deleted the datasets branch January 14, 2024 06:21
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants