-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figure.timestamp: Deprecate parameter 'justification' to 'justify' (remove in v0.13.0) #3002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emove in v0.13.0)
seisman
added
deprecation
Deprecating a feature
needs review
This PR has higher priority and needs review.
labels
Jan 15, 2024
Summary of changed imagesThis is an auto-generated report of images that have changed on the DVC remote
Image diff(s)Added imagesModified images
Report last updated at commit bcb668d |
Although
So, it's time to give this method a final review, then we can categorize it as "Ongoing maintenance". |
Co-authored-by: Yvonne Fröhlich <[email protected]>
michaelgrund
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
We use the parameter
justify
in many modules (e.g.,text
,plot
) but usejustification
inFigure.timestamp
. This PR deprecates thejustification
parameter tojustify
to make it consistent in the project.FYI, the GMT project also use
justify
as the long option name: https://github.com/GenericMappingTools/gmt/blob/0c3435fba382755a87ba7629cbe1db288c2a9a60/src/gmt_common_longoptions.h#L86Since it's a rarely used module, I think it's OK to fully remove the deprecated parameter after two releases (i.e., v0.13.0).