Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure: Remove deprecated "xshift" ("X") and "yshift" ("Y") parameters, use "Figure.shift_origin" instead (deprecated since v0.8.0) #3044

Merged
merged 11 commits into from
Feb 28, 2024

Conversation

yvonnefroehlich
Copy link
Member

@yvonnefroehlich yvonnefroehlich commented Feb 6, 2024

Description of proposed changes

This PR removes the deprecated xshift (X) and yshift (Y) parameters from all plotting methods (deprecated since v0.8.0). The standalone method Figure.shift_origin should be used instead.

Fixes partly #3033
Related to #2071

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash command is:

  • /format: automatically format and lint the code

@yvonnefroehlich yvonnefroehlich added the deprecation Deprecating a feature label Feb 6, 2024
@yvonnefroehlich yvonnefroehlich changed the title All plotting methods: Remove deprecated 'xshift' ('X') and 'yshift' ('Y') parameters, use 'Figure.shift_origin' instead (deprecated since v0.8.0) All plotting methods: Remove deprecated "xshift" ("X") and "yshift" ("Y") parameters, use "Figure.shift_origin" instead (deprecated since v0.8.0) Feb 6, 2024
@seisman seisman added this to the 0.12.0 milestone Feb 27, 2024
@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Feb 27, 2024
@seisman seisman changed the title All plotting methods: Remove deprecated "xshift" ("X") and "yshift" ("Y") parameters, use "Figure.shift_origin" instead (deprecated since v0.8.0) Figure: Remove deprecated "xshift" ("X") and "yshift" ("Y") parameters, use "Figure.shift_origin" instead (deprecated since v0.8.0) Feb 28, 2024
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Feb 28, 2024
@seisman seisman merged commit 44f4ffd into main Feb 28, 2024
20 of 21 checks passed
@seisman seisman deleted the rem-depr-xyshift branch February 28, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Deprecating a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants