Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure.plot3d: Refactor to increase code readability #3143

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Conversation

seisman
Copy link
Member

@seisman seisman commented Mar 27, 2024

Description of proposed changes

Same as #2742 but for Figure.plot3d. The changes are almost the same, except that the default point style is s0.2c in Figure.plot but is u0.2c in Figure.plot3d.

@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog needs review This PR has higher priority and needs review. labels Mar 27, 2024
@seisman seisman added this to the 0.12.0 milestone Mar 27, 2024
@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Mar 27, 2024
@seisman seisman merged commit dbbc168 into main Mar 28, 2024
21 checks passed
@seisman seisman deleted the refactor/plot3d branch March 28, 2024 08:05
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants