Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for typesetting quotation marks #3179

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Conversation

seisman
Copy link
Member

@seisman seisman commented Apr 18, 2024

Issue #3104 should be automatically addressed in #3132. This PR adds a test for it to make sure that everything works as expected.

Closes #3104.

@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog labels Apr 18, 2024
@seisman seisman added this to the 0.12.0 milestone Apr 18, 2024
Copy link
Contributor

Summary of changed images

This is an auto-generated report of images that have changed on the DVC remote

Status Path
added pygmt/tests/baseline/test_text_quotation_marks.png

Image diff(s)

Added images

  • test_text_quotation_marks.png

Modified images

Path Old New

Report last updated at commit f1d24e9

@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Apr 18, 2024
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Apr 18, 2024
@seisman seisman merged commit 62872d3 into main Apr 18, 2024
20 of 21 checks passed
@seisman seisman deleted the text/quotation-marks branch April 18, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Figure.text sometimes doesn't work if the text contains single/double quotation marks
2 participants