Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the data_kind and validate_data_input functions #3335

Merged
merged 11 commits into from
Jul 20, 2024
Merged

Refactor the data_kind and validate_data_input functions #3335

merged 11 commits into from
Jul 20, 2024

Commits on Jul 17, 2024

  1. Make _validate_data_input public and move it to Session.virtualfile_in

    @seisman
    seisman committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    e79a7d0 View commit details
    Browse the repository at this point in the history

  2. Remove test_data_kind_fails because it's already covered by validate_… 

    …data_input doctests
    @seisman
    seisman committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    e2a8ceb View commit details
    Browse the repository at this point in the history

  3. Remove the unused x/y/z/required_z parameters from data_kind

    @seisman
    seisman committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    008a56f View commit details
    Browse the repository at this point in the history

  4. data_kind: Change the parameter name from required_data to required

    @seisman
    seisman committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    46fb307 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. Update docstrings

    @seisman
    seisman committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    d3854da View commit details
    Browse the repository at this point in the history

  2. Fix a typing hints issue

    @seisman
    seisman committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    a9670aa View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. Make validate_data_input private

    @seisman
    seisman committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    7ff0d9e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into refactor/data-kind

    @seisman
    seisman committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    70962d0 View commit details
    Browse the repository at this point in the history

  3. Improve the docstrings of the data_kind function

    @seisman
    seisman committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    b575591 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into refactor/data-kind

    @seisman
    seisman committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    c522e36 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2024

  1. Merge branch 'main' into refactor/data-kind

    @seisman
    seisman committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    0bde17d View commit details
    Browse the repository at this point in the history