-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figure.legend: Support passing a StringIO object as the legend specification #3438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…O object as inputs
…lfile-from-stringio
7 tasks
seisman
force-pushed
the
legend/stringio
branch
from
September 13, 2024 06:27
44b6e22
to
c2b3ee1
Compare
This reverts commit 486fce7.
seisman
force-pushed
the
legend/stringio
branch
from
September 13, 2024 09:25
c2b3ee1
to
b01c254
Compare
seisman
force-pushed
the
legend/stringio
branch
from
September 13, 2024 09:33
8f7b647
to
f434356
Compare
seisman
force-pushed
the
legend/stringio
branch
from
September 13, 2024 10:46
86f71e3
to
dfab3c7
Compare
seisman
changed the title
POC + WIP: Figure.legend: Support passing a StringIO object as the legend specification
Figure.legend: Support passing a StringIO object as the legend specification
Sep 13, 2024
5 tasks
weiji14
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Nice to close another >4 year old issue at #571!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This PR adds StringIO support to
Figure.legend
, so that we can pass a StringIO object containing the legend specification toFigure.legend
.Need to wait for #3326.Closes #571 and #576.
Example