-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split tests related to virtualfiles into multiple test files #3512
Conversation
CodSpeed Performance ReportMerging #3512 will not alter performanceComparing Summary
Benchmarks breakdown
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we keep test_inquire_virtualfile
in test_clib_virtualfiles.py
? I'd like to keep that file so that we can still look back at the git history more easily.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I've renamed test_clib_open_virtualfiles.py
back to test_clib_virtualfiles.py
.
For inquire_virtualfile
, I plan to add more tests about GMT_IN
in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, that works too, thanks!
Description of proposed changes
Split
pygmt/tests/test_clib_virtualfiles.py
into:Note that
open_virtualfile
tests remain intest_clib_virtualfiles.py
.Addresses #3351 (comment).
Previous split at #2784.