-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump minimum required GMT from 6.0.0rc5 to 6.0.0 #363
Conversation
Set minimum required GMT in our continuous integration scripts and configuration files to use GMT 6.0.0 from the main conda-forge channel. Remove some references to conda-forge/label/dev channel.
Team, I need to rush off now but will be back in a couple of hours. Have a look to see if I've missed out on anything. Website preview at https://pygmt-git-fork-weiji14-gmt600.gmt.now.sh/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. My only suggestion is to encourage users to ask questions or discuss on the GMT forum.
Sure, had the same thought actually. Do we still want to keep gitter around for a while? |
Not a full removal of gitter, but this should get the attention of most people. Include a new shields.io style badge too on the main README!
Ok, I've updated most of the obvious contact links to the new discourse forum but kept the old gitter.im on the main README for now. There's actually a surprising amount of webhooks to gitter (which links to the old gmt-python gitter chat instead of pygmt...), and stuff like PyPI contact info I'm cautious not to touch. Should open up a new PR to discuss about purging those (or not). Will merge this in as is for now though. |
Cross referencing GenericMappingTools/pygmt#363,
Cross referencing GenericMappingTools/pygmt#363,
Hi @weiji14 and @seisman, thanks for keeping things going! I would just like to ask if you could slow down a little bit. I've been having very limited time to work on this but I think PRs should be discussed, particularly when we have to consider wording choices or introduction of new functions. It's easy to add things but changing or removing them later can be a huge hassle if we're being good to our users and not breaking things. So I prefer to think deeply before merging. As a courtesy, please allow for at least 2-3 days for discussion before rushing to merge (unless it's something trivial). Thanks! |
Sorry if this came out as ungrateful. I really really appreciate all that you two have done (and continue to do) for the project! I don't want to be a bottle neck on most things and you two have admin rights to the repository for a reason. |
Noted 👌. I definitely got a bit carried away recently, especially with GMT6 being released (got excited after have been waiting for almost a year!). That's not really an excuse though, and I do apologize for my haste. The 2-3 days cooldown sounds good, since we'll need to appreciate the different timezones and work-life balance of our diverse contributors going forward ⏩. |
Description of proposed changes
GMT6 is finally released, so we can simplify our conda installation steps and update the documentation accordingly.
TODO:
Fixes #362, Supersedes #351
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.