-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn all short aliases into long form #474
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
c75d2d1
Turn common aliases from short form to long form
weiji14 1e14b72
Fix fmt_docstring test
weiji14 144effa
Alias U as timestamp instead of logo
weiji14 2223ae2
Remove short aliases for makecpt
weiji14 f5fc1a3
Remove short aliases for surface
weiji14 8906d59
Add common alias interpolation (n) for grdtrack
weiji14 db842e7
Remove short alias for which and refactor test
weiji14 71fb973
Remove short aliases from coast
seisman f131cd5
Remove short aliases from colorbar
seisman 57f25ea
Improve docstring of colorbar
seisman ce6e84f
Remove short aliases from grdcontour
seisman cb5fb41
Remove short aliases from legend
seisman ac6aad3
Remove short aliases for logo
seisman 52b8d0c
Aliased per_column(C), spacing(I), nearest_multiple(T) for info
weiji14 aa369dc
Remove short aliases for psconvert and improve fmt docstring
weiji14 718e786
Add U to docstring of grdcontour
seisman b8f7b33
Remove short aliases for plot
seisman 30136d5
Remove short aliases for contour
seisman c320756
Improve docstring of text
weiji14 d9a3290
Remove short alias from image
weiji14 d87b7e4
Use frame instead of B for basemap.
weiji14 e3b5183
Fix a typo "book"->"bool"
seisman 15b9c6b
Alias map_scale(L), rose(Td), compass(Tm) for basemap
weiji14 a1f5839
Change x, y to x/y in docstrings to make it look nicer
weiji14 8869feb
Fix string to str in docstrings
seisman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No long alias for
C
in coast? GMT.jl usesriver_fill
, but has a system to handle lakes/rivers separately using a tuple. See https://www.generic-mapping-tools.org/GMT.jl/latest/coast/. We could doriverlake_fill
😆There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm hesitating to add new long-name aliases in this PR. We should have more discussions in separate issues (i.e., one issue for each module), as we don't want to break backward compatibility due to some stupid names.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I had a feeling it wasn't just randomly left out. Will treat it as an exception now then.