-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix several failures due to updates of earth relief data #498
Conversation
Does that mean we don't need the cross-platform workaround as in #438 anymore? |
Not sure. It yes, the GitHub Actions CI (#475) would be greatly simplified. 🤞 |
Now there are only 13 failures (image differences). Two of the Windows CI jobs still fail to download the earth_relief_10m grid, leading to one more failure. |
Should we merge in #495 first then, just to update the cache key and see if will work? |
OR, we can merge #495 into this PR, and then merge this PR into master if the 2 tests pass for Windows. |
I don't think PR #495 really updates the caches. Look at the latest CI reports of that PR, it still tries to download all the files. Possibly because the caching post-job won't run if the any CI steps fail. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, that is super annoying. Let's just merge in this one, since it's just a problem with the cache on Windows (and not an actual problem with the function we're trying to test).
Should we move all the closed issues linked to the 0.2.x milestone to 0.1.x milestone? |
Done, and I'll move some of the open ones to 0.1.x too. |
Description of proposed changes
Update some numbers due to the recent changes in GMT earth relief data.
Partially address #451.
Note: For unknown reasons, the caches of the Azure Pipelines expire and there is always a cache miss.
Each CI job will download the data files from the GMT data server.
It seems the long-time internet connection issue in Azure Pipelines is gone, and all files are downloaded without timeouts.
Reminders
make format
andmake check
to make sure the code follows the style guide.doc/api/index.rst
.