Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove expected failures on grdview tests #589

Merged
merged 11 commits into from
Sep 9, 2020
Merged

Remove expected failures on grdview tests #589

merged 11 commits into from
Sep 9, 2020

Commits on Sep 6, 2020

  1. Remove xfail on test_grdview_grid_file_with_region_subset which xpasses

    @weiji14
    weiji14 committed Sep 6, 2020
    Configuration menu
    Copy the full SHA
    aeea98b View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2020

  1. Merge remote-tracking branch 'upstream/master' into remove_grdview_xf… 

    …ails
    @weiji14
    weiji14 committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    3f9d7ab View commit details
    Browse the repository at this point in the history

  2. Add region fixture and use check_figures_equal on two tests

    @weiji14
    weiji14 committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    9b01e1e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into remove_grdview_xfails

    @weiji14
    weiji14 committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    f16213c View commit details
    Browse the repository at this point in the history

  4. Refactor test to use new check_figures_equal syntax from #590

    @weiji14
    weiji14 committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    ac26993 View commit details
    Browse the repository at this point in the history

  5. Use check_figures_equal on previously xfailing grdview tests

    @weiji14
    weiji14 committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    cb7ff98 View commit details
    Browse the repository at this point in the history

  6. Refactor grdview test to use grdcut instead of load_earth_relief 

    The xarray based slicing isn't as precise as grdcut, so some images were a few pixels off when plotted in 3D.
    @weiji14
    weiji14 committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    ba67c4f View commit details
    Browse the repository at this point in the history

  7. Add result_images folder to gitignore and make clean list

    @weiji14
    weiji14 committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    08380a5 View commit details
    Browse the repository at this point in the history

  8. Rename grid explicitly to xrgrid, and use kwargs to reduce code length

    @weiji14
    weiji14 committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    611d0a3 View commit details
    Browse the repository at this point in the history

  9. Set a Transverse Mercator projection for zaxis_frame test 

    Otherwise GMT (fig_ref) might plot double-lined x and y axis frame, while PyGMT (fig_test) plots a single-lined frame.
    @weiji14
    weiji14 committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    79248c0 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2020

  1. Merge branch 'master' into remove_grdview_xfails

    @weiji14
    weiji14 committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    569be3a View commit details
    Browse the repository at this point in the history