Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use short affiliations in AUTHORS.md #957

Merged
merged 3 commits into from
Feb 23, 2021

Conversation

core-man
Copy link
Member

Description of proposed changes

Use short affiliations instead of the full ones in AUTHORS.md, because the full affiliations sometimes are longer than one line in GitHub web UI, and more than 200 characters in the plaintext markdown file.

Fixes #897

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@welcome
Copy link

welcome bot commented Feb 23, 2021

💖 Thanks for opening this pull request! 💖

Please make sure you read our contributing guidelines and abide by our code of conduct.

A few things to keep in mind:

  • If you need help writing tests, take a look at the existing ones for inspiration. If you don't know where to start, let us know and we'll walk you through it.
  • All new features should be documented. It helps to write the docstrings for your functions/classes before writing the code. This will help you think about your code design and results in better code.
  • No matter what, we are really grateful that you put in the effort to do this! 🎉

AUTHORS.md Outdated Show resolved Hide resolved
@seisman seisman added this to the 0.3.1 milestone Feb 23, 2021
@seisman seisman added documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog labels Feb 23, 2021
Co-authored-by: Dongdong Tian <[email protected]>
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Ping @GenericMappingTools/python for second round of review.

@liamtoney
Copy link
Member

Looks good to me. Thanks @core-man!

@seisman seisman merged commit e057927 into GenericMappingTools:master Feb 23, 2021
@welcome
Copy link

welcome bot commented Feb 23, 2021

🎉🎉🎉 Congrats on merging your first pull request and welcome to the team! 🎉🎉🎉

Please open a new pull request to add yourself to the AUTHORS.md file. We hope that this was a good experience for you. Let us know if there is any way that the contributing process could be improved.

@core-man core-man deleted the short-affiliations branch February 23, 2021 21:03
@weiji14
Copy link
Member

weiji14 commented Feb 23, 2021

Please open a new pull request to add yourself to the AUTHORS.md file. We hope that this was a good experience for you. Let us know if there is any way that the contributing process could be improved.

Thanks @core-man! Definitely add your name to the AUTHORS.md list too when you feel like it 😉

@core-man
Copy link
Member Author

Please open a new pull request to add yourself to the AUTHORS.md file. We hope that this was a good experience for you. Let us know if there is any way that the contributing process could be improved.

Thanks @core-man! Definitely add your name to the AUTHORS.md list too when you feel like it

Thanks a lot for the remind @weiji14. I will do it when I am ready to contribute more and regularly to the meaningful project.

sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Short affiliation names in AUTHORS.md
4 participants