Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lighthouse issues #109

Open
Atulin opened this issue Oct 2, 2024 · 0 comments
Open

Lighthouse issues #109

Atulin opened this issue Oct 2, 2024 · 0 comments

Comments

@Atulin
Copy link
Collaborator

Atulin commented Oct 2, 2024

  • /staff
    • The page cannot be cached because it has a BroadcastChannel instance with registered listeners.
    • Image elements do not have explicit width and height
    • Avoid document.write()
    • Image elements do not have [alt] attributes
    • Document doesn't have a <title> element
    • /api/useractivity responded with 401 which logged errors to the console
    • robots.txt is not valid Lighthouse was unable to download a robots.txt file
  • /user/tsparkle
    • Reduce unused JavaScript (/dist/vue.min.js)
    • Pages whose main resource has cache-control:no-store cannot enter back/forward cache.
    • Image elements do not have explicit width and height
    • Serve images in next-gen formats (all is .png)
    • Background and foreground colors do not have a sufficient contrast ratio.
  • /blog/post/24/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa
    • Heading elements are not in a sequentially-descending order (<h4>No comments found</h4>)
  • /story/7/get-clean-dirty-moon
    • Reduce unused JavaScript (/dist/vue.min.js)
Atulin added a commit that referenced this issue Oct 3, 2024
@Atulin
Addressed some issues from #109
efa79f4 
- Added alt, width, height to some of the images that were missing it
- Removed broadcast channel, it was really only used for debugging
- Lack of comments info is now a regular ol' span instead of a h4
- Staff page now has a title *and* a description
- Last active endpoint no longer needs authorization so it will always respond with 2xx, thus, not logging any errors to the console
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Atulin