Translation providers improvements #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntains other language, add translate all, translate only empty. Also experiment support in suggestion (disabled for now - list of xpath is not supported, only one xpath at a time).
josegar74
reviewed
Mar 13, 2024
| @@ -32,225 +32,176 @@ | |||
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | |||
| xmlns:xsl="http://www.w3.org/1999/XSL/Transform" | |||
| xmlns:xs="http://www.w3.org/2001/XMLSchema" | |||
| xmlns:gn-fn-metadata="http://geonetwork-opensource.org/xsl/functions/metadata" | |||
| xmlns:geonet="http://www.fao.org/geonetwork" | |||
There was a problem hiding this comment.
Is it required a template to remove geonet elements also, other xslt in the process folder has that type of template?
in the same xslt for iso19139 this line doesn't exist.
There was a problem hiding this comment.
For harvesting no. I only tested suggestion with 115-3 for now but turned it off as it requires a bit more effort. Maybe we can check later when we add translation service in the editor and also align 19139 ?
There was a problem hiding this comment.
geonet namespace is required for suggestion templates
* Create a script
```js
var mock = {
parameter:{
q:'hello',
source:'en',
target:'fr'
}
};
function doGet(e) {
e = e || mock;
var sourceText = ''
if (e.parameter.q){
sourceText = e.parameter.q;
}
var sourceLang = '';
if (e.parameter.source){
sourceLang = e.parameter.source;
}
var targetLang = 'en';
if (e.parameter.target){
targetLang = e.parameter.target;
}
var translatedText = LanguageApp.translate(sourceText, sourceLang, targetLang, {contentType: 'html'});
return ContentService.createTextOutput(translatedText).setMimeType(ContentService.MimeType.JSON);
}
```
* Deploy it as webapp for anonymous user
* Configure the service URL in the translation provider
…iguration. Add examples for easier XPath configuration.
fxprunayre
changed the title
fxprunayre
changed the title
josegar74
reviewed
Apr 18, 2024
...viders/src/main/java/org/fao/geonet/translations/googletranslate/GoogleTranslateService.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/fao/geonet/translations/libretranslate/LibreTranslateClientException.java
Outdated
Show resolved
Hide resolved
web-ui/src/main/resources/catalog/components/admin/harvester/HarvesterDirective.js
Show resolved
Hide resolved
josegar74
reviewed
Apr 18, 2024
web-ui/src/main/resources/catalog/components/admin/harvester/partials/translate.html
Outdated
Show resolved
Hide resolved
web-ui/src/main/resources/catalog/components/admin/harvester/partials/translate.html
Outdated
Show resolved
Hide resolved
…/googletranslate/GoogleTranslateService.java
…/libretranslate/LibreTranslateClientException.java
…artials/translate.html
…artials/translate.html
josegar74
approved these changes
Apr 18, 2024
josegar74
added a commit
that referenced
this pull request
Jun 3, 2024
* Support for translation providers in harvesters * Support for translation providers / fix artifact in services/pom.xml * Support for translation providers / directive to select multiple languages * Support for translation providers / update harvester translation and use ACE Editor widget for translation fields configuration * Support for translation providers / refactor directive to select multiple languages to be generic * Support for translation providers / directive to select multiple languages - use a watcher to initialize typeahead when the data is available * Translation providers improvements (#98) * Support for translation providers / Better handle record which may contains other language, add translate all, translate only empty. Also experiment support in suggestion (disabled for now - list of xpath is not supported, only one xpath at a time). * Support for translation providers / Add google translate service * Create a script ```js var mock = { parameter:{ q:'hello', source:'en', target:'fr' } }; function doGet(e) { e = e || mock; var sourceText = '' if (e.parameter.q){ sourceText = e.parameter.q; } var sourceLang = ''; if (e.parameter.source){ sourceLang = e.parameter.source; } var targetLang = 'en'; if (e.parameter.target){ targetLang = e.parameter.target; } var translatedText = LanguageApp.translate(sourceText, sourceLang, targetLang, {contentType: 'html'}); return ContentService.createTextOutput(translatedText).setMimeType(ContentService.MimeType.JSON); } ``` * Deploy it as webapp for anonymous user * Configure the service URL in the translation provider * Support for translation providers / Add Anchor support. * Support for translation providers / Create one directive for the configuration. Add examples for easier XPath configuration. * Support for translation providers / Improve translation. * Support for translation providers / Fix bad xpath. * Update translationproviders/src/main/java/org/fao/geonet/translations/googletranslate/GoogleTranslateService.java * Update translationproviders/src/main/java/org/fao/geonet/translations/libretranslate/LibreTranslateClientException.java * Update web-ui/src/main/resources/catalog/components/admin/harvester/partials/translate.html * Update web-ui/src/main/resources/catalog/components/admin/harvester/partials/translate.html --------- Co-authored-by: Jose García <[email protected]> * Translation providers - support additional harvesters: GeoNetwork, Local filesystem, OAI-PHM, WebDav --------- Co-authored-by: François Prunayre <[email protected]>
josegar74
added a commit
that referenced
this pull request
Jun 18, 2024
* Support for translation providers in harvesters * Support for translation providers / fix artifact in services/pom.xml * Support for translation providers / directive to select multiple languages * Support for translation providers / update harvester translation and use ACE Editor widget for translation fields configuration * Support for translation providers / refactor directive to select multiple languages to be generic * Support for translation providers / directive to select multiple languages - use a watcher to initialize typeahead when the data is available * Translation providers improvements (#98) * Support for translation providers / Better handle record which may contains other language, add translate all, translate only empty. Also experiment support in suggestion (disabled for now - list of xpath is not supported, only one xpath at a time). * Support for translation providers / Add google translate service * Create a script ```js var mock = { parameter:{ q:'hello', source:'en', target:'fr' } }; function doGet(e) { e = e || mock; var sourceText = '' if (e.parameter.q){ sourceText = e.parameter.q; } var sourceLang = ''; if (e.parameter.source){ sourceLang = e.parameter.source; } var targetLang = 'en'; if (e.parameter.target){ targetLang = e.parameter.target; } var translatedText = LanguageApp.translate(sourceText, sourceLang, targetLang, {contentType: 'html'}); return ContentService.createTextOutput(translatedText).setMimeType(ContentService.MimeType.JSON); } ``` * Deploy it as webapp for anonymous user * Configure the service URL in the translation provider * Support for translation providers / Add Anchor support. * Support for translation providers / Create one directive for the configuration. Add examples for easier XPath configuration. * Support for translation providers / Improve translation. * Support for translation providers / Fix bad xpath. * Update translationproviders/src/main/java/org/fao/geonet/translations/googletranslate/GoogleTranslateService.java * Update translationproviders/src/main/java/org/fao/geonet/translations/libretranslate/LibreTranslateClientException.java * Update web-ui/src/main/resources/catalog/components/admin/harvester/partials/translate.html * Update web-ui/src/main/resources/catalog/components/admin/harvester/partials/translate.html --------- Co-authored-by: Jose García <[email protected]> * Translation providers - support additional harvesters: GeoNetwork, Local filesystem, OAI-PHM, WebDav --------- Co-authored-by: François Prunayre <[email protected]>
juanluisrp
pushed a commit
that referenced
this pull request
Jul 23, 2024
…onetwork#8190) * Support for translation providers in harvesters * Support for translation providers / fix artifact in services/pom.xml * Support for translation providers / directive to select multiple languages * Support for translation providers / update harvester translation and use ACE Editor widget for translation fields configuration * Support for translation providers / refactor directive to select multiple languages to be generic * Support for translation providers / directive to select multiple languages - use a watcher to initialize typeahead when the data is available * Translation providers improvements (#98) * Support for translation providers / Better handle record which may contains other language, add translate all, translate only empty. Also experiment support in suggestion (disabled for now - list of xpath is not supported, only one xpath at a time). * Support for translation providers / Add google translate service * Create a script ```js var mock = { parameter:{ q:'hello', source:'en', target:'fr' } }; function doGet(e) { e = e || mock; var sourceText = '' if (e.parameter.q){ sourceText = e.parameter.q; } var sourceLang = ''; if (e.parameter.source){ sourceLang = e.parameter.source; } var targetLang = 'en'; if (e.parameter.target){ targetLang = e.parameter.target; } var translatedText = LanguageApp.translate(sourceText, sourceLang, targetLang, {contentType: 'html'}); return ContentService.createTextOutput(translatedText).setMimeType(ContentService.MimeType.JSON); } ``` * Deploy it as webapp for anonymous user * Configure the service URL in the translation provider * Support for translation providers / Add Anchor support. * Support for translation providers / Create one directive for the configuration. Add examples for easier XPath configuration. * Support for translation providers / Improve translation. * Support for translation providers / Fix bad xpath. * Update translationproviders/src/main/java/org/fao/geonet/translations/googletranslate/GoogleTranslateService.java * Update translationproviders/src/main/java/org/fao/geonet/translations/libretranslate/LibreTranslateClientException.java * Update web-ui/src/main/resources/catalog/components/admin/harvester/partials/translate.html * Update web-ui/src/main/resources/catalog/components/admin/harvester/partials/translate.html --------- * Translation providers - support additional harvesters: GeoNetwork, Local filesystem, OAI-PHM, WebDav --------- Co-authored-by: François Prunayre <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better handle record which may contains languages
Configuration
Add google translate service
Based on https://stackoverflow.com/questions/8147284/how-to-use-google-translate-api-in-my-java-application
Misc
Checklist
mainbranch, backports managed with labelREADME.mdfilespom.xmldependency management. Update build documentation with intended library use and library tutorials or documentation