Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GNIP-66: curated_thumbs contrib application #4726

Closed
capooti opened this issue Aug 9, 2019 · 4 comments
Closed

GNIP-66: curated_thumbs contrib application #4726

capooti opened this issue Aug 9, 2019 · 4 comments
Assignees
Labels
gnip A GeoNodeImprovementProcess Issue
Milestone

Comments

@capooti
Copy link
Member

capooti commented Aug 9, 2019

Hello GeoNode developers

we have the following requirement: in many cases GeoNode users would like to be able to upload a static image that can be used in place of the automatically GeoNode generated thumbnail.

We would like to develop a contrib application which, when added in INSTALLED_APPS, will act in the following way:

  • in the edit layer/map form, there will be a new button, named "Upload" in the Thumbnail section
  • clicking on the button, the user will get to an "Upload thumbnail" page, identical for layers and maps
  • the user will be able to upload a thumbnail to be associated with the layer/map. If an image is uploaded, then it will be used as the thumbnail for that layer/map. Otherwise the usual GeoNode behaviour will keep going

How GeoNode would be impacted when the contrib application is used:

  • there won't be any schema change in existing tables
  • there will be a new model (table) which will keep a 1-1 relation with base_resourcebase
  • thumbnail_url will be dehydrated in geonode/api/resourcebase_api.py (only when the extension is used) in order to return the static image url in place of the thumbnail
  • the edit layer/map form will have a new "upload thumbnail" button
  • a new page with the upload thumbnail feature will be available

Please provide your feedback (maybe with changes/improvements), and I would soon send a PR with this new contrib application.

@capooti capooti added the gnip A GeoNodeImprovementProcess Issue label Aug 9, 2019
@capooti capooti self-assigned this Aug 9, 2019
@t-book
Copy link
Contributor

t-book commented Aug 9, 2019

Thanks, @capooti I would very welcome this. +1.

It would be great to have some settings option which filesize and types are allowed (maybe even svg :)) By the way have you seen there is an upload option in mapstore for thumbs as well nevertheless I like the idea of a viewer independent contrib app.

@afabiani
Copy link
Member

@capooti +1 nice feature.

There's already a similar feature available for Documents by default since a long time

image

image

@t-book
Copy link
Contributor

t-book commented Aug 17, 2019

@capooti As the PR has already been merged. Can we close this issue?

@capooti
Copy link
Member Author

capooti commented Aug 19, 2019

yes let's close this @t-book

@capooti capooti closed this as completed Aug 19, 2019
@afabiani afabiani added this to the 2.10.1 milestone Aug 20, 2019
@afabiani afabiani added feature A new feature to be added to the codebase and removed feature A new feature to be added to the codebase labels Aug 20, 2019
@afabiani afabiani changed the title GNIP: curated_thumbs contrib application GNIP-66: curated_thumbs contrib application Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gnip A GeoNodeImprovementProcess Issue
Projects
None yet
Development

No branches or pull requests

3 participants