Implements GNIP for curated-thumbs app #4731
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4731 +/- ##
==========================================
+ Coverage 59.49% 59.56% +0.06%
==========================================
Files 230 236 +6
Lines 12261 12301 +40
Branches 1774 1776 +2
==========================================
+ Hits 7295 7327 +32
- Misses 4376 4383 +7
- Partials 590 591 +1 |
|
... moreover, I don't see neither tests nor documentation. This is a brand new functionality which goes to core. I guess we need something more clean. |
afabiani
requested changes
Aug 14, 2019
There was a problem hiding this comment.
- Some files are missing osgeo headers.
- There's no documentation. At least the user guide should be updated.
- No test present, we need at least one showing that actually, the thumbnails changed.
- I would align Documents also. Why having such functionality only for Maps and Layers?
- Any reason to have a specific app for that functionality? It this will be enabled by default, I don't see the need to have it separated
| @@ -0,0 +1 @@ | |||
| # -*- coding: utf-8 -*- | |||
| @@ -0,0 +1 @@ | |||
| # -*- coding: utf-8 -*- | |||
|
Thanks Alessio |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the GNIP for curated-thumbs #4726
Here is an animated gif with the new feature:
http://g.recordit.co/JaKutevbrT.gif
It has an additional requirement: django-imagekit
Thumbnails are implemented for layers and maps. It would be very easy to implement them for documents as well but I see that there is already this feature (let me know if you want to replace it with this for homogeneity).
I decided to implement the application as an internal application for GeoNode as I believe this is useful for any GeoNode instance. If you believe it should rather go to a contrib application, I am ready to migrate it to geonode-contribs.