-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fixes #11421] Improvements for DownloadHandler #11423
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattiagiupponi
requested review from
giohappy and
afabiani
and removed request for
giohappy
August 28, 2023 14:28
5 tasks
giohappy
reviewed
Aug 30, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #11423 +/- ##
==========================================
+ Coverage 61.86% 61.94% +0.08%
==========================================
Files 867 867
Lines 51435 51584 +149
Branches 6454 6467 +13
==========================================
+ Hits 31818 31955 +137
- Misses 18080 18090 +10
- Partials 1537 1539 +2 |
giohappy
reviewed
Sep 5, 2023
giohappy
approved these changes
Sep 8, 2023
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-4.1.x 4.1.x
# Navigate to the new working tree
cd .worktrees/backport-4.1.x
# Create a new branch
git switch --create backport-11423-to-4.1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 cd70285a2c92732bded9905584e305a4fde9ac77
# Push it to GitHub
git push --set-upstream origin backport-11423-to-4.1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-4.1.x Then, create a pull request where the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #11421
Checklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.