-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fixes #ISSUE_11995] GNIP 99: Implement a CRUD REST API for users #12072
Conversation
* [Fixes #11995] Implement POST and PATCH methods for the User API * Upgrare Remote Docker for CircleCI * [Fixes #11995] Implement POST and PATCH methods for the User API, refactored validation in serializer --------- Co-authored-by: RegisSinjari <[email protected]> Co-authored-by: Giovanni Allegri <[email protected]>
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
9702486 | Triggered | Generic Password | a411232 | geonode/people/tests.py | View secret |
9702486 | Triggered | Generic Password | a411232 | geonode/people/tests.py | View secret |
9768717 | Triggered | Username Password | a411232 | geonode/people/tests.py | View secret |
9705160 | Triggered | Username Password | a411232 | geonode/base/api/tests.py | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
Doc PR provided by @RegisSinjari available GeoNode/documentation#302 |
@RegisSinjari please check the failing test |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #12072 +/- ##
==========================================
+ Coverage 63.67% 64.04% +0.36%
==========================================
Files 867 867
Lines 52664 53173 +509
Branches 6600 6650 +50
==========================================
+ Hits 33535 34053 +518
+ Misses 17610 17591 -19
- Partials 1519 1529 +10 |
Implementation of the user CRUD api described in #11995
cc: @RegisSinjari
Checklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.