-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fixes #12124] GNIP 100: Assets #12338
Conversation
* [Fixes #12124] GNIP 100: Assets --------- Co-authored-by: etj <[email protected]>
[Fixes #12226] Directory assets --------- Co-authored-by: etj <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12338 +/- ##
==========================================
+ Coverage 64.14% 64.17% +0.03%
==========================================
Files 872 886 +14
Lines 52328 53279 +951
Branches 6478 6584 +106
==========================================
+ Hits 33564 34194 +630
- Misses 17275 17571 +296
- Partials 1489 1514 +25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's to restore a mandatory argument made optional (or to explain why it was changed) and then it's ok for me (it's 99.99% of the code I did :D )
The PR should be REBASED AND MERGED |
Checklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.