Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASCII support #3105

Merged
merged 3 commits into from
Jun 29, 2017
Merged

ASCII support #3105

merged 3 commits into from
Jun 29, 2017

Conversation

ismailsunni
Copy link
Contributor

Make GeoNode supports asc file uploader.

At first I just want to make the support available with QGIS Server backend, but it seems it will work also on geoserver. This PR is only addressing the GeoServer backend one. The QGIS Server backend will be added in the another PR (since we move qgis_server to geonode).

cc @gubuntu @lucernae

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 46.337% when pulling c05923c9df6d340d6c529da428e5111733344a7d on ismailsunni:ascii_support into 0bbeba0 on GeoNode:master.

@ismailsunni
Copy link
Contributor Author

Btw, I want to add unit test, but I can't find asc file in the gisdata package. I made a PR to add an asc file to the gisdata package: GeoNode/gisdata#6

@afabiani
Copy link
Member

afabiani commented Jun 5, 2017

@ismailsunni is this PR ready to merge? Or you still have some commits to push? Also, can you update the branch (or I can do this for you)?

@ismailsunni
Copy link
Contributor Author

Hi @afabiani
I have updated the branch.

Actually, I want to add a unit test for uploading the asc file, but there is no asc file in the gisdata package. If it's ok to not add that test, the PR is ready to merge.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 46.33% when pulling a9888cf686b8c157cb51801257bc8b95c2bc1b0b on ismailsunni:ascii_support into aca964c on GeoNode:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 46.327% when pulling 4cfd28e on ismailsunni:ascii_support into ed7be5b on GeoNode:master.

@afabiani
Copy link
Member

afabiani commented Jun 7, 2017

@ismailsunni of course if does not require too much effort to you, having test cases would be good. This would allow us to be sure the code still works in the future. Let me know if you have time to add tests or you prefer to close the PR as is.

In any case, before closing it, I will try to test it also on my side.

Thanks again for you work.

@pjdufour
Copy link
Member

pjdufour commented Jun 8, 2017

I have a simple question. What is the purpose of an .asc file in this context? Thanks.

@afabiani
Copy link
Member

afabiani commented Jun 9, 2017

@pjdufour @ismailsunni .asc files are types of Rasters handled by geospatial server. However, as far as I know, it is not sufficient to upload the .asc file, also a correct .prj file must be uploaded along with the file data. The code should also check that both the files are present.

@gubuntu
Copy link

gubuntu commented Jun 9, 2017

ultimately asc will be one of many raster formats supported but for now we're implementing GeoTiff and asc download support because they are the formats currently used by the InaSAFE backend.

The QGIS backend already turned those into TMS caches but since TH and users also need to download the original raster, we fast-tracked that implementation.

@afabiani afabiani merged commit 9c3b6b0 into GeoNode:master Jun 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants