-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPCgeonode #4024
SPCgeonode #4024
Conversation
- tests run in parralel - docker layers cache works
- cleanup - remove custom setting files and use env vars instead - move envvars to docker-compose when possible - run tests without async - fix async - ci : cache per branch
Codecov Report
@@ Coverage Diff @@
## master #4024 +/- ##
=======================================
Coverage 54.34% 54.34%
=======================================
Files 235 235
Lines 15131 15131
Branches 2257 2257
=======================================
Hits 8223 8223
Misses 6175 6175
Partials 733 733 |
Very good @olivierdalang At a first glance it looks ok. Give me some time to try and test it locally. |
@olivierdalang many thanks for this very valuable addition |
Thanks @olivierdalang +1 to merge |
Good work @olivierdalang. At first look it seems to work well with docker-machine too even if I had some issue with the upload. I have to try it again with a vm with more memory. Left a couple of comments along the PR though. Also I want to check it out in a linux virtual machine. What would the plan be to get rid of images coming from your docker hub account? Do we want to keep them during the beta period? |
+1 on seeing this get merged in. It would make developing for geonode locally quite a bit easier. |
Hi,
As discussed during last PSC meeting and on the ML, and following the GNIP #3707, here's my proposition for upstreaming SPCgeonode.
During the meeting, we agreed on having this in a dedicated repo in under the Geonode organisation (following the Geonode-project approach that SPCgeonode had so far). But it's actually much more practical to have it in the main repo, so that the setup is also usable when developing Geonode.
Everything is nicely contained under scripts/spcgeonode, so that it would not interfere with the current setup if we merge this into master. The only thing outside of that folder is the config for CI, so I used CircleCI instead of Travis to avoid any interferences.
Quickstart :
Check
scripts/spcgeonode/README.md
for more details...Features :
docker-compose up -d
and everything should work out of the box)docker-compose up -d --build django postgres nginx geoserver
)As already said, I think this may be a solution to our current problem with releases (where it seems it's too much work for what we currently can provide to make new releases for Ubuntu, let alone other systems such as Windows).
Suggested action plan :
Let me know what you think.
Cheers,
Olivier