-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT] Remove AngularJS from Geonode Search. #4246
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@francbartoli Regarding the use of jQuery: there are a couple of components rely on it, such as TextSearchForm and SelectionTree. Perhaps we can address its removal in a future phase of refactoring? |
Skeleton of bdd tests for search
Main concern was about still using if for ajax call even though getting rid of jquery would be better. Thanks for addressing bdd tests |
@trepagnier closing this since it is stale for a long time and has conflicts.
Thanks, |
This PR is connected to #4129. It is an early draft that will complete the items listed below. The list will grow in number and detail as work on this PR progresses:
functions
directory.Search
factory function. An instance ofSearch
will be used to store all data related to searching the Geonode catalogue. This instance should be regarded as the single source of truth for all search related data. Any stateful components or modules should receive their state from the Search instance.$scope
and a givenSearch
instance, which will be used until Angular is entirely removed from the project.