[Fixes #4322] SESSION_EXPIRED_CONTROL_ENABLE=True breaks GeoNode

[afabiani]

No description provided.

[codecov]

Codecov Report

Merging #4343 into master will decrease coverage by 0.25%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4343      +/-   ##
==========================================
- Coverage   57.98%   57.72%   -0.26%     
==========================================
  Files         202      203       +1     
  Lines       11718    11838     +120     
  Branches     1683     1713      +30     
==========================================
+ Hits         6795     6834      +39     
- Misses       4375     4454      +79     
- Partials      548      550       +2

[afabiani]

@frafra seems like spc_geonode does not like the session middleware at all :|

[frafra]

@afabiani tests seem to work only if you wait for a while before running them, maybe because of the 60 seconds timeout you added.

A similar issue happens with the standard Docker setup, and should be avoided in my opinion, or at least we should have a simple and robust mechanism to determine if the system is ready to be used or not. I would prefer to avoid API-only solutions, as even a user should be aware if the platform is ready or not, and if you have your system running with a nice homepage the user will think that everything is fine, while it is not.

[afabiani]

@frafra agree, any suggestion? I'll start thinking about a solution too as soon as I can devote some time here again.

[afabiani]

@frafra ... which timeout? The DB one?

[afabiani]

@frafra what about a geonode endpoint http://localhost:8000/gs/online returning a json {"online": false} or {"online": false} whenever the LOCAL_GEOSERVER is up or not?

[t-book]

least we should have a simple and robust mechanism to determine if the system is ready to be used or not.

@frafra what about a geonode endpoint http://localhost:8000/gs/online returning a json {"online": false} or {"online": false} whenever the LOCAL_GEOSERVER is up or not?

I haven´t followed all of the discussion but why would it not be enough checking the status code of geoserver endpoint?

as even a user should be aware if the platform is ready or not,

+1 for informing users whenever gs is down.

fetch('/geoserver/web/').then(function(response) {
  if (response.status !== "200") {
    alert("warning geoserver is offline")
});

[frafra]

@frafra ... which timeout? The DB one?

Yes, but I am not sure if that's what causes the issue.

@frafra what about a geonode endpoint http://localhost:8000/gs/online returning a json {"online": false} or {"online": false} whenever the LOCAL_GEOSERVER is up or not?

In that scenario, how to determine if LOCAL_GEOSERVER is up? Should we check if GeoServer returns a 2xx HTTP code? We are already doing that in geonode-selenium, thanks to Docker healthchecks, but it is still failing on this pull request.

I haven´t followed all of the discussion but why would it not be enough checking the status code of GeoServer endpoint?

That's what is already happening. It seems to me that there are certain cases where GeoNode and GeoServer can be both up and running, but not ready to accept uploads. It would be nice to understand why, because we could fix the standard Docker setup too (which is not possible to test automatically with geonode-selenium because we do not know when it is really ready to be tested #4259).

[afabiani]

@frafra uhm, I'm not fully sure it is a timeout problem here. It looks to me more a setup issue instead. Something related to the fixtures, not loaded correctly or something. However, I'll investigate a bit more on this as soon as I have some time slots available.

[afabiani]

@frafra @t-book, for the time being, I will set the property to "False" by default and I will add (in the next commit) appropriate documentation.

I then will open a specific issue about this "spc-geonode" behavior described above.

[afabiani]

@frafra @t-book with the latest commits:

1. The Django message framework now uses the cookie store, thus avoiding to lock the DB
2. The SESSION_EXPIRED_CONTROL_ENABLED is set to False by default and can be enabled to Env
3. Updated tutorials/advanced/geonode_settings/settings.html variables by describing the new variable setting

This PR also refers to #4325 "List of documentation improvements" by refactoring the tutorials/advanced/geonode_settings/settings.txt accordingly.

[t-book]

Great @afabiani. Thanks a lot for this. The blocking does not occur in dev setup anymore and hence the issue is fixed for me.
@frafra This should solve the docker issue as well?

[afabiani]

I'm going to merge this and address the SPC GeoNode issue here

#4350

[frafra]

@t-book I am not sure about that, but we will see :)