Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #5629 GNIP 72 - Delete docs folder #5789

Merged
merged 3 commits into from
Mar 2, 2020
Merged

Conversation

t-book
Copy link
Contributor

@t-book t-book commented Mar 1, 2020

New docs repository is filled.
Read the docs is connected.

as last missing step:
This PR deletes the docs from Master.

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemptions is, changes not visible to end users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there are explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Mar 1, 2020
@t-book t-book requested a review from afabiani March 1, 2020 21:22
@codecov
Copy link

codecov bot commented Mar 2, 2020

Codecov Report

Merging #5789 into master will decrease coverage by 2.35%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5789      +/-   ##
==========================================
- Coverage    58.2%   55.85%   -2.36%     
==========================================
  Files         172      172              
  Lines       19459    19459              
  Branches     3208     3208              
==========================================
- Hits        11327    10869     -458     
- Misses       7117     7607     +490     
+ Partials     1015      983      -32

@t-book
Copy link
Contributor Author

t-book commented Mar 2, 2020

hi @afabiani the start page pointed to 2.10.x branch at RTD which since today does not exist anymore hence selenium fails

I've fixed it here: 81dcc5e

Without this commit all other PRs will fail as well. Let's wait if Travis is happy

@afabiani afabiani merged commit 2bb1556 into GeoNode:master Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants