Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): Post GNOME 47 runtime updates #1118

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Conversation

Rafostar
Copy link
Contributor

With GNOME 47 runtime, latest GStreamer version is included so we do not have to build anything else for Clapper anymore. Remove GStreamer from CI building and move Clapper to main manifest where all the other sources are.

GNOME 47 runtime is based on Freedesktop runtime 24.08, so we should be using a ffmpeg-full version made for this parent runtime.

With GNOME 47 runtime, latest version is included so we do not have
to build anything else for Clapper anymore.

Remove GStreamer from CI building and move Clapper to main manifest
where all the other sources are.
GNOME 47 runtime is based on Freedesktop runtime 24.08, so we
should be using a ffmpeg-full version made for this parent runtime.
@Rafostar
Copy link
Contributor Author

Huh. Seems that flatpak-builder in git already has 47 (and its in README), but stable release from git actions marketplace does not. We can either wait with this MR until its updated in marketplace or just drop last commit and continue with 43 for now...

@Rafostar Rafostar marked this pull request as draft September 20, 2024 10:39
@GeopJr
Copy link
Owner

GeopJr commented Sep 20, 2024

Awesome, thanks!

just drop last commit and continue with 43 for now...

Yeah, just drop it. The action version has little to do with the actual runtimes. The main branch already depends on GNOME 47's libraries!

Use latest flatpak-builder version to build Flatpak packages.
@Rafostar
Copy link
Contributor Author

OK. Lets just update the builder action while at it.

@Rafostar Rafostar changed the title fix(ci): Post GNOME 47 runtime updates feat(ci): Post GNOME 47 runtime updates Sep 20, 2024
Fixup to make MPRIS work again after adding multiple player instances support
@Rafostar
Copy link
Contributor Author

Tested with Builder and works great. 👍
I also fixed MPRIS permission that we missed last time while adding multiple instances support.

@Rafostar Rafostar marked this pull request as ready for review September 20, 2024 19:10
@GeopJr
Copy link
Owner

GeopJr commented Sep 20, 2024

Thank you so much! I'll probably include it in the main flatpak in the next release :)

@Rafostar
Copy link
Contributor Author

I'll probably include it in the main flatpak in the next release

Awesome, but... there still isn't a Clapper stable that would have downloads cache ability unfortunately 😞 (it helps a lot for looping "GIF-videos").

@GeopJr
Copy link
Owner

GeopJr commented Sep 20, 2024

I don't have a schedule for the next release, but I can switch the flatpak to Clapper whenever cache makes it to stable without having to make a new Tuba release (since we've already implemented everything on Tuba's side)!

@GeopJr GeopJr merged commit 80ea3e4 into GeopJr:main Sep 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants