feat(ScaleRevealer): finish crossfade early #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Made it ease in-out so it hits more progress points, made progress limit 0.3 and optimized snapshoting to skip the whole cross fading process as we only need to snapshot the child |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #1122 ?
Previously the transition would crossfade between the source widget (attachment) and the target one (mediaviewer) relatively to the transition progress. That creates a seamless transition between them. However as shown on #1122, it also creates an unintended effect around the middle point.
For context, the media viewer's black background's opacity is also relative to the animation.
This PR changes it so as long as the animation progress is over 20%, it won't crossfade. This still looks a bit off, maybe just to me because I've seen it in slow mode.
Another idea would be to make the media viewer's background's opacity get darker sooner so the distorted snapshot of the attachment is not that visible?
whichever the path forward might be, this PR can be optimized further so it's a draft. (we can skip snapshoting the source on over 20% since the fade effect is done).