-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shiny new widgets \o/ #405
Conversation
Thank you so much for this PR! I haven't finished reviewing everything yet but I'll start with some comments (there's no rush or expectations!) |
b495fec
to
a8798d0
Compare
a8798d0
to
5244ec5
Compare
What's the status here? Would be sweet to have this in the next release, with GNOME 45 coming out next month :) |
This is good to go from my side, except I'd probably have to rebase, and use the 45 runtime instead of master. @GeopJr probably needs to do another round of review and testing. |
This is not stale but I have postponed it until the cleanup PR (#424) is done! |
5244ec5
to
01b5722
Compare
Hi, while using this branch I noticed some deprecation warnings and that the preferences dialog could use other new libadwaita widgets. I've made the changes in this fork and after testing it, it seems that everything works fine although it never hurts to test it more, especially the one that replaces AdwLeaflet in the new account dialog. Feel free to cherry-pick the commits or I can open a PR against this branch if you want 😄 |
Main is now somewhat ready, could you rebase @bugaevc? There have been many changes in that cleanup PR, most importantly for this PR however: All ListBoxes became ListViews. When in a scrolledwindow they have to be in the following structure: GtkScrolledWindow -> AdwClampScrollable -> ListView. No boxes or other children as it will cause issues with the ListView's size. That might need some changes in anything that inherits from the Base widget (I've kind-of rushed the cleanup PR a bit since I didn't want to make rebasing even more difficult so there might be bugs!) If you are busy, let me know and I'll rebase it instead! |
These are the shiny new replacements for AdwLeaflet and AdwFlap.
These messages are very verbose (possibly many messages per second), yet not interesting to a regular user, they're only for developers debugging the app. Yet, they were logged to the system journal at the NOTICE level, which is higher (numerically smaller) than even INFO, and so were highligheted as important in the journalctl output. Downgrade the logging to use debug (), which results in the messages not being logged to the journal at all by default. It is still possible to see the debugging messages by setting G_MESSAGES_DEBUG=Tuba (or "all").
Instead of GtkSwitch and GtkSpinButton
Using AdwViewSwitcher
Using AdwNavigationView
01b5722
to
5d4d1e0
Compare
Yay! Rebased (that took some work) & added @oscfdezdz's changes. Since Please review & test! |
Just built the branch and gave it a spin, a few things I noticed (not all necessarily coming from this MR, haven't tested the app in a while):
|
Thanks and sorry about that 🙇 Everything looks good, I'll go ahead and merge it! Thank you so much for making this PR!
Nice catch! I'll get on it on a different PR!
This PR is only the start of #228, as long as they are in the mockup (they are), we'll get there! |
Hi,
this is an attempt to port Tuba to the new libadwaita widgetry (click, click). I'm not an expert in GTK, nor in Tuba's codebase, so I most likely messed something up — please let me know!
This PR only touches the main window (and not even all of its views?), not the compose dialog.