Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(LWW): remove hack #644

Merged
merged 2 commits into from
Dec 21, 2023
Merged

feat(LWW): remove hack #644

merged 2 commits into from
Dec 21, 2023

Conversation

GeopJr
Copy link
Owner

@GeopJr GeopJr commented Nov 17, 2023

No description provided.

@bugaevc
Copy link
Contributor

bugaevc commented Nov 17, 2023

If you're no longer setting label.ellipsize to anything but NONE, you should be able to remove more of this code (old_ellipsize, new_ellipsize, ...)

@GeopJr
Copy link
Owner Author

GeopJr commented Nov 17, 2023

Done!

@GeopJr GeopJr marked this pull request as ready for review December 21, 2023 22:26
@GeopJr GeopJr merged commit 28331ab into main Dec 21, 2023
5 checks passed
@GeopJr GeopJr deleted the feat/LWW/remove-hack branch December 21, 2023 22:26
@GeopJr GeopJr mentioned this pull request Dec 21, 2023
Closed
This was referenced Jan 26, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GeopJr @bugaevc