fix(SecretAccountStore): workaround DONT_MATCH_NAME #742
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #701 #114 again
What's did #701 do?
When searching for secrets (saved accounts) in the keyring, we encountered issues with the keyring not unlocking in some setups. The solution was to retrieve ALL secrets that match the schema and not just Tuba's (#134, #114). However when working on another app that used the same schema as Tuba's I noticed that the two were reading each other's secrets and failing to load them (as expected) so I reverted the change on #701. Now there are two problems, both #114 and the one just described.
What does this PR do?
It reverts #701 but to prevent the new problem, it checks if the label is "Mastodon Account" (not so reliable) and if
xdg:schema
matches the app id (dev.geopjr.Tuba
) and skips the secret if it doesn't.