Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support PHP 8.1 #14

Merged
merged 5 commits into from
Mar 6, 2023
Merged

Support PHP 8.1 #14

merged 5 commits into from
Mar 6, 2023

Conversation

paul-m
Copy link
Contributor

@paul-m paul-m commented Feb 28, 2023

No description provided.

@paul-m
Copy link
Contributor Author

paul-m commented Mar 1, 2023

opis/json-schema ^1.0.8 gives us a necessary bug fix for PHP 8.1

@paul-m paul-m requested a review from jastraat March 2, 2023 21:51
jastraat
jastraat reviewed Mar 3, 2023
View reviewed changes
Copy link

@jastraat jastraat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paul-m I don't see code climate on this one...? (for real this time) Do we want to include that?

@paul-m
Copy link
Contributor Author

paul-m commented Mar 3, 2023

@dafeder wiggled the wires at codeclimate, and I pushed the correct codeclimate id. seems to be working now.

jastraat
jastraat approved these changes Mar 6, 2023
View reviewed changes
Copy link

@jastraat jastraat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All matrix automated tests for PHP 7.4, 8.0, and 8.1 passing (as well as with prefer lowest setting). Codesniffer with PSR1 and PSR2 rules. And Codeclimate. Looks good!

@jastraat jastraat merged commit 9771788 into master Mar 6, 2023
@jastraat jastraat deleted the support-php81 branch March 6, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jastraat jastraat jastraat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paul-m @jastraat