Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap React Strap for USWDS #119

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Swap React Strap for USWDS #119

wants to merge 3 commits into from

Conversation

dgading
Copy link
Member

@dgading dgading commented Feb 12, 2021

This work will run parallel with GetDKAN/data-catalog-app#54 where we move from React strap to USWDS as the primary design system. This will have backward incompatible changes in terms of styling, so it will be a new release. In an effort to streamline the component library, there are a few components up for deprecation either because they are no longer used in the demo site, a cleaner way can be done with USWDS, or they are over engineered for their functionality.

Components/Services/Templates progress

When checked off we can say these are ready for 2.0.0 release. If it is staying it will have unit tests (including accessibility check) and documentation. If it is deprecated, we have an update on the component in the 1.x branch letting developers know it is being deprecated along with the notice on the Docz file. Services are for the most part considered deprecated here as they are moving to https://github.com/GetDKAN/data-catalog-services.

New Components:

Existing Components:

  • ApiDocs
  • DataIcon
  • DataTable
    • DataTableDensity
    • DataTablePageResults
    • DataTablePageSizer
    • ManageColumns
      • Card
      • Index
  • FileDownload
  • FormatIcon
    • Index
    • Icon
  • IconList
  • IconListItem
  • Logo
  • Menu
  • Modal
  • Organization Clean up Organization component  #120
  • PageHeader
  • PublisherList
  • Resource
  • SearchFacets
    • Index
    • SearchFacet
  • SearchInput
  • SearchList
  • SearchListItem
  • SearchPageSizer
  • SearchPaginationResults
  • SearchResultsMessage
  • SearchSort
  • ShowMoreContainer
  • String => DEPRECATE
  • Table
  • Tags
  • Text => DEPRECATE
  • ToggleBlock
  • TopicWrapper => DEPRECATE

Services:

  • resource
  • Search

Templates:

  • Announcement => DEPRECATE
  • Blocks
    • Index => RECREATE AS USWDS CARD
    • BasicBlock => DEPRECATE
    • StatBlock => MOVE TO COMPONENT
    • StepsBlock => DEPRECATE
  • DataTable
  • DataTableHeader
  • Footer
  • Header
  • Hero
  • NavBar
  • SearchContent
  • SearchSidebar
  • TopicIcon => MOVE TO ICONS

@dgading dgading marked this pull request as draft February 12, 2021 17:54
@dgading dgading added this to the v2.0.0 milestone Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant