Add chromium. #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As convenient as using electron is with cypress tests, in some instances a "real" browser does things in a different way that can prevent some errors.
Specifically our cypress test were suffering from this error: https://stackoverflow.com/questions/59629575/cypress-tests-failing-because-chrome-renderer-is-crashing-in-ci-using-drone. We implemented the solution given in that stackoverflow question, but it was not enough. In other sources it was suggested to use headles chrome or chromium. That solution did work for us.
We generally want to keep this container lean, but due to limitations with cypress we can not use a remote browser: cypress-io/cypress#5984
For now the solution is for us to install chromium for cypress to use.