Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Dictionary Data Types #4173

Merged
merged 10 commits into from
May 21, 2024
Merged

Data Dictionary Data Types #4173

merged 10 commits into from
May 21, 2024

Conversation

kaise-lafrai
Copy link
Contributor

@kaise-lafrai kaise-lafrai commented Apr 30, 2024

fixes [org/repo/issue#]

  • Test coverage exists
  • Documentation exists

QA Steps

  • Navigate to Data Dictionary Form here /node/add/data?schema=data-dictionary
  • Fill out required fields
  • Select Add field
  • Confirm you see these new data types under the Data type dropdown:
    datetime
    year
    boolean
  • Select datetime and confirm you see the following format options
    default
    any
    other
  • Select year and confirm you see the following format options
    default
  • Select boolean and confirm you see the following format options
    default
  • Confirm when selecting each data type that the description below shows the correct descriptions.
  • Datetime
    The format of the data in this field. Supported formats depend on the specified field type:
    default: An ISO8601 format string of datetime.
    any: Any parsable representation of a date. The implementing library can attept to parse the datetime via a range of strategies.
    other: If your date values follow a collective but non-ISO8601 pattern, select this option and define the incoming format using the syntax of C / Python strftime. For example, if your data had dates formatted as MM/DD/YYYY, you would enter %m/%d/%Y into the Other format field.
  • Year
    The format of the data in this field. Supported formats depend on the specified field type:
    default: 4-digit numbers in the range 1901 to 2155.
  • Boolean
    The format of the data in this field. Supported formats depend on the specified field type:
    default: 1/0 values, or True/False values (not case sensitive).
  • Continue adding/editing fields and confirm all the above still functions correctly.

Copy link
Member

@janette janette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the descriptions on Year and Boolean

modules/data_dictionary_widget/src/Fields/FieldValues.php Outdated Show resolved Hide resolved
modules/data_dictionary_widget/src/Fields/FieldValues.php Outdated Show resolved Hide resolved
Copy link
Member

@janette janette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last change, can you update the format description for the 'number' option from "Any valid string" to "An exact fixed-point number. No non-numeric characters allowed other than the decimal."

https://github.com/GetDKAN/dkan/pull/4173/files#diff-0b145a5ba4f24440bf1ff9183143eb7b2ca0d6389a79bbf0b52b484e735c5a32R127

@janette janette merged commit 013f2c1 into 2.x May 21, 2024
10 checks passed
@janette janette deleted the Data-Dictionary-Data-Types branch May 21, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants