Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new config_target property in the datastore settings form #4183

Open
wants to merge 1 commit into
base: 2.x
Choose a base branch
from

Conversation

jastraat
Copy link
Contributor

@jastraat jastraat commented May 8, 2024

This is a demonstration of the new way of tying configuration properties directly to form elements as of Drupal 10.2. This won't be backwards compatible to versions before Drupal 10.2.

fixes [org/repo/issue#]

  • Test coverage exists
  • Documentation exists

QA Steps

  • Change the settings on admin/dkan/resources and save
  • Export configuration and confirm that the changes are reflected in the exported configuration.

@jastraat jastraat requested a review from paul-m May 8, 2024 01:15
@jastraat
Copy link
Contributor Author

jastraat commented May 8, 2024

@paul-m I mostly wanted to use this PR to remind myself of some of the Drupalcon config validation talk and demonstrate the changes in a concrete way; I know DKAN isn't ready yet to drop 10.1. (Although it does lose security support REALLY soon!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants