Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run fulltext index alters one at at time #4288

Merged
merged 6 commits into from
Oct 16, 2024
Merged

Run fulltext index alters one at at time #4288

merged 6 commits into from
Oct 16, 2024

Conversation

janette
Copy link
Member

@janette janette commented Sep 16, 2024

[error]  SQLSTATE[HY000]: General error: 1795 InnoDB presently supports one FULLTEXT index creation at a time 

When defining multiple fulltext indexes in a data dictionary, user will get this error when running the post_import queue.

Describe your changes

Updating the buildAddIndexOptions method in the datastore/DataDictionary MySQLQuery class so that the fulltext indexes are split off for executing one at a time.

QA Steps

details: 22521

  • Create a dictionary with some standard indexes and some fulltext indexes.
  • Use the data dictionary 'reference' mode
  • Create/Edit a dataset to use the dictionary you just created.
  • Run the queues
  • Confirm the queues run without error.
  • Confirm the import dashboard concurs.
  • Confirm the indexes on the datastore table align with the data dictionary.
  • Confirm the data typing also aligns with the data dictionary.

Checklist before requesting review

If any of these are left unchecked, please provide an explanation

  • I have updated or added tests to cover my code
  • I have updated or added documentation

@janette janette changed the title Run fulltext index alters separately from standard index alters Run fulltext index alters one at at time Sep 16, 2024
@janette janette marked this pull request as ready for review September 30, 2024 21:14
@rovcase
Copy link
Contributor

rovcase commented Oct 10, 2024

Looks good here- as we talked about via huddle going to look into created a test for the catch before we merge.

Copy link
Contributor

@rovcase rovcase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@rovcase rovcase merged commit 92d049d into 2.x Oct 16, 2024
11 checks passed
@rovcase rovcase deleted the fulltext-alter branch October 16, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants