Feature/data modifier plugin #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
thierrydallacroce
commented
Jan 10, 2020
•
thierrydallacroce
commented
- Add a data modifier annotation-type plugin
- Potentially modifies output of publicly accessible endpoints in metastore schemas, datastore sql query and dataset-specific api docs
- Add a dkan_alt_api module, disabled by default
- Add a dkan_non_public module, disabled by default, implementing a data modifier plugin to protect resources of non-public datasets
* Shorten function name, improve comments, force plugin to state schemas to modify * Add non-public data modifier, disabled by default
* Add annotations to communicate result, http code in json responses * Adjust unit test's expected message from the plugin
fmizzell
suggested changes
Jan 10, 2020
* Remove schemasToModify from the base class * Use setter injection in the metastore for our plugin manager * Fix unit tests in Metastore service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.