Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First draft of search api integration. #295

Merged
merged 32 commits into from
Feb 6, 2020
Merged

First draft of search api integration. #295

merged 32 commits into from
Feb 6, 2020

Conversation

fmizzell
Copy link
Contributor

No description provided.

@fmizzell fmizzell added the WIP label Jan 15, 2020
@fmizzell fmizzell removed the WIP label Feb 4, 2020
thierrydallacroce
thierrydallacroce reviewed Feb 4, 2020
View reviewed changes
modules/custom/dkan_search/README.md Outdated
@@ -0,0 +1,23 @@
@page search Search
The search module provides some integration with [search_api](https://www.drupal.org/project/search_api) to facilitate querying DKAN's metadata.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The search dkan_search module

modules/custom/dkan_search/src/WebServiceApi.php Outdated
* Search.
*/
public function search() {
$storage = \Drupal::service("entity.manager")->getStorage('search_api_index');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't entity.manager deprecated? I believe entity_type.manager is recommended.

@thierrydallacroce
Copy link
Contributor

  • If it’s not already disabled, we should uninstall the dkan_lunr module before removing its code.
  • I see where dkan_lunr is no longer made a requirement of dkan2, but I don’t see how or where dkan_search is add or made a dependency.

@thierrydallacroce thierrydallacroce merged commit c22fbab into master Feb 6, 2020
@thierrydallacroce thierrydallacroce deleted the search-api branch February 6, 2020 02:03
thierrydallacroce added a commit that referenced this pull request Feb 11, 2020
@thierrydallacroce
Merge branch 'master' into improve-put-and-patch-when-data-does-not-c…
ca52422 
…hange

* master:
  Add custom node content view (#255)
  First draft of search api integration. (#295)
  Update SQL Endpoint example URL in docs (#305)
  Reinstate admin/content view (#302)
thierrydallacroce added a commit that referenced this pull request Feb 12, 2020
@thierrydallacroce
Merge branch 'master' into start-with-revisioning-capabilities
a4e6257 
* master:
  Add custom node content view (#255)
  First draft of search api integration. (#295)
  Update SQL Endpoint example URL in docs (#305)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thierrydallacroce thierrydallacroce thierrydallacroce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fmizzell @thierrydallacroce @janette