Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cabal flag to allow TH, embed assets during compilation and disembed them on the spot #1

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add cabal flag to allow TH, embed assets during compilation and disembed them on the spot #1

wants to merge 4 commits into from

Conversation

viviag
Copy link

@viviag viviag commented Oct 6, 2017

@viviag
Copy link
Author

viviag commented Oct 6, 2017 •
edited
Loading

I think we need kind of Snap.Util.FileServe for embedded files.
So I can fork it and try to write with upstream PR after. Or I can write it here. Or I can switch to wai+servant locally here as in servant-swagger-ui (and it will hardly become part of origin). Or I misunderstand something.
Anyway is this comment suitable for us?
Current state - decided to write own module to serve embedded files.

@viviag
Copy link
Author

viviag commented Oct 11, 2017 •
edited
Loading

Embedding and extraction functions are tested in ghci with cabal repl

Upd: Working locally.

@viviag viviag changed the title WIP: Add cabal flag to allow TH, embed assets and serve them Add cabal flag to allow TH, embed assets and serve them Oct 11, 2017
@viviag viviag requested review from fizruk and removed request for fizruk October 12, 2017 12:11
@viviag viviag requested review from fizruk and removed request for fizruk October 19, 2017 13:37
@viviag viviag changed the title Add cabal flag to allow TH, embed assets and serve them Add cabal flag to allow TH, embed assets during compilation and disembed them on the spot Oct 23, 2017
@fizruk fizruk mentioned this pull request Oct 29, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fizruk fizruk Awaiting requested review from fizruk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@viviag