Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove two invisible chars in a guide #4511

Merged
merged 3 commits into from
Nov 28, 2022
Merged

Conversation

petyosi
Copy link
Contributor

@petyosi petyosi commented Nov 25, 2022

  • fix broken link

🎯 Goal

Docusaurus reports the link as broken due to two invisible characters.

🛠 Implementation details

Removed them.

🎨 UI Changes

N/A

Milko

@petyosi petyosi requested a review from a team as a code owner November 25, 2022 07:10
@petyosi petyosi requested review from a team, MarinTolic and JcMinarro November 25, 2022 07:10
@petyosi petyosi changed the base branch from main to develop November 25, 2022 07:11
@GetStream GetStream deleted a comment from github-actions bot Nov 25, 2022
@skydoves
Copy link
Member

Nice catch! Thank you for creating this, @petyosi.

@petyosi petyosi force-pushed the remove-invisible-chars-in-docs branch from 773f5d3 to 16d86b3 Compare November 25, 2022 10:24
Copy link
Member

@skydoves skydoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 💯

@skydoves skydoves enabled auto-merge (rebase) November 28, 2022 01:25
@skydoves skydoves merged commit 8934cbf into develop Nov 28, 2022
@skydoves skydoves deleted the remove-invisible-chars-in-docs branch November 28, 2022 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants